fix missing aot model SourceGenerationContext #1636
Merged
+50
−12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
approved
…netesClientSourceGenerator
k8s-ci-robot
added
size/M
There was a problem hiding this comment.
Pull Request Overview
This PR fixes the missing AOT model SourceGenerationContext by introducing a dedicated template and generator while updating tests and dependency registrations. Key changes include:
- Adding a new test method (VersionTestAsync) to validate the client's version retrieval.
- Introducing a new SourceGenerationContext template and generator.
- Removing duplicate SourceGenerationContext code from ModelExtensions.cs.template and updating generator registrations.
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| tests/E2E.Aot.Tests/MinikubeTests.cs | Added a new async test to verify version retrieval. |
| src/LibKubernetesGenerator/templates/SourceGenerationContext.cs.template | Created a new AOT SourceGenerationContext template. |
| src/LibKubernetesGenerator/templates/ModelExtensions.cs.template | Removed duplicate SourceGenerationContext generation code. |
| src/LibKubernetesGenerator/SourceGenerationContextGenerator.cs | Added a generator for rendering the new SourceGenerationContext template. |
| src/LibKubernetesGenerator/KubernetesClientSourceGenerator.cs | Registered the new SourceGenerationContextGenerator in the dependency injection container. |
Comments suppressed due to low confidence (3)
tests/E2E.Aot.Tests/MinikubeTests.cs:379
- [nitpick] The 'VersionTestAsync' method currently only checks for a non-null version. Consider asserting specific properties or format of the version to strengthen test coverage.
Assert.NotNull(version);
src/LibKubernetesGenerator/templates/ModelExtensions.cs.template:15
- [nitpick] The removal of the SourceGenerationContext generation block helps reduce duplication. Ensure that the new SourceGenerationContext template and its generator fully cover the intended behavior.
#if NET8_0_OR_GREATER
src/LibKubernetesGenerator/KubernetesClientSourceGenerator.cs:62
- [nitpick] Verify that introducing the SourceGenerationContextGenerator registration does not affect the initialization order or dependencies among the generators.
builder.RegisterType<SourceGenerationContextGenerator>();
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: brendandburns, tg123 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#1633